Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining Link UI tests to Playwright #52828

Merged
merged 53 commits into from
Oct 9, 2023
Merged

Migrate remaining Link UI tests to Playwright #52828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
2b4e8b0
migrate test: will use Post title as link text if link to existing po…
MaggieCabrera Jul 21, 2023
7375f64
removed old test
MaggieCabrera Jul 21, 2023
19f10e4
migrated test: can be created by selecting text and clicking Link
MaggieCabrera Jul 21, 2023
5922929
removed old test
MaggieCabrera Jul 21, 2023
c27f885
migrated test: will not automatically create a link if selected text …
MaggieCabrera Jul 21, 2023
5ebaa1d
updated snapshots and migrated test: can be created without any text …
MaggieCabrera Jul 21, 2023
2e4bf04
migrated test: can be created instantly when a URL is selected
MaggieCabrera Jul 21, 2023
46690c7
migrated test: is not created when we click away from the link input
MaggieCabrera Jul 21, 2023
24742f7
migrated test: can be edited
MaggieCabrera Jul 21, 2023
53894d9
migrated test: can be removed
MaggieCabrera Jul 31, 2023
4882d3c
test migrated: allows Left to be pressed during creation when the too…
MaggieCabrera Aug 7, 2023
10bd381
test migrated: allows Left to be pressed during creation in Docked to…
MaggieCabrera Aug 7, 2023
5611f0b
migrate test: can be edited with collapsed selection
MaggieCabrera Aug 8, 2023
f3be083
migrated test: allows use of escape key to dismiss the url popover
MaggieCabrera Aug 11, 2023
c5f7d49
migrated test: can be modified using the keyboard once a link has bee…
MaggieCabrera Aug 11, 2023
5c5ac41
removed comment
MaggieCabrera Aug 11, 2023
4b7aa65
improved selector
MaggieCabrera Aug 17, 2023
86d13f6
migrated test: adds an assertive message for screenreader users when …
MaggieCabrera Aug 17, 2023
c61b0a1
migrated test: should not display text input when initially creating …
MaggieCabrera Aug 17, 2023
482c2de
migrated test: should display text input when the link has a valid UR…
MaggieCabrera Aug 17, 2023
4882bf5
migrated test: should preserve trailing/leading whitespace from linke…
MaggieCabrera Aug 17, 2023
245cb45
migrated test: should allow for modification of link text via Link UI
MaggieCabrera Aug 17, 2023
8316bb9
migrated test: capture the text from the currently active link even i…
MaggieCabrera Aug 17, 2023
656a113
migrated test: should not show the Link UI when selection extends bey…
MaggieCabrera Aug 17, 2023
5e050f5
migrated test: should not show the Link UI when selection extends int…
MaggieCabrera Aug 17, 2023
7008bf8
migrated test: should correctly replace targetted links text within r…
MaggieCabrera Aug 17, 2023
67e015a
Apply re-wording suggestions from Code Review
getdave Oct 4, 2023
83d639c
Fix broken test due to upsteam changes
getdave Oct 4, 2023
54ccc21
Create test post using REST
getdave Oct 4, 2023
43f878b
Prefer concretions in tests
getdave Oct 4, 2023
f3ca9b3
Use requestUtils to create post
getdave Oct 4, 2023
7dd8c43
Improve test resilience by using more precise selector
getdave Oct 4, 2023
5abfc4e
Further improvements to test resilience by using more precise selectors
getdave Oct 4, 2023
e0c7448
Provide context to usage of `getByPlaceholder`
getdave Oct 5, 2023
1c410d8
Update other uses of getByPlaceholder
getdave Oct 5, 2023
d98cc13
Remove redundant comment
getdave Oct 5, 2023
82ea296
Simplify test to essentials and provide context
getdave Oct 5, 2023
0ff1879
Add util to cover inaccessible selection of Link Popover
getdave Oct 5, 2023
4fa90c3
Improve arrow key under link test
getdave Oct 5, 2023
de9e684
Improve test desc
getdave Oct 5, 2023
500e3df
Abstract direct usage of CSS locator in anticipation of refactor
getdave Oct 5, 2023
4cc632f
Make sure test is testing what is says it will
getdave Oct 5, 2023
6b9c271
Use standard helper
getdave Oct 5, 2023
1e7f8ef
Shuffle test order
getdave Oct 5, 2023
87b9c43
Improve test resilience by avoiding reliance on tab stops
getdave Oct 5, 2023
064641d
Use standard utils
getdave Oct 5, 2023
cd7a935
Replace custom query with standard util
getdave Oct 5, 2023
44b832f
Make it clear which button is being targetted
getdave Oct 5, 2023
adef5f3
Improve test comprehension by using more than simply a period
getdave Oct 5, 2023
eb41c29
Increase test comprehensibility but improving assertions
getdave Oct 5, 2023
6aa08d8
Avoid use of keyboard where not necessary
getdave Oct 5, 2023
d4a6043
Apply nits from code review
getdave Oct 9, 2023
8635538
Improve comment
getdave Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions packages/e2e-tests/specs/editor/various/__snapshots__/links.test.js.snap
View file
Open in desktop

This file was deleted.

Loading
Loading