-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project management: automate adding package-related labels to PRs #52729
base: trunk
Are you sure you want to change the base?
Conversation
|
||
"[Package] A11y": | ||
- packages/a11y/** | ||
#"[Package] ": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some packages don't have an associated label. This is direct to solve, and labels should be created later for these packages, but I didn't want to interfere with the WIP audit in #52583.
Flaky tests detected in 9973baa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5587437804
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's beyond my skillset to comment on the code itself - but in terms of the labels being added it looks good to me
Thanks for taking a look, @jordesign . There are some label mismatches between the current labels and packages, as I noted in the spreadsheet from #52583. Since package labels should be a direct 1:1 mapping, I will move forward to updating them if you don't mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, and should help the problem quite a bit. Looks thorough to me but I will hold off on approval until you have the label mismatches sorted.
Slightly unrelated and maybe it would have been better addressed in the contrext of #52583 I just noticed that there's no label for the existing package Actual use case: I'd need the missing label to be added to #54148 |
What?
This PR automates adding package-related labels to PRs when they affect one or more npm packages. Related discussions in #52583 and #52727 (comment)
Why?
Labeling in detail is a burden, and often PRs get merged without many labels. Some labels can be automated, like package labels and many feature-related ones.
How?
By adding a labeler GitHub action that checks the path of the files affected by the PRs.
Testing Instructions
I've created a PoC in a test repository, and it seems to work fine!