Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project management: automate adding package-related labels to PRs #52729

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

priethor
Copy link
Contributor

What?

This PR automates adding package-related labels to PRs when they affect one or more npm packages. Related discussions in #52583 and #52727 (comment)

Why?

Labeling in detail is a burden, and often PRs get merged without many labels. Some labels can be automated, like package labels and many feature-related ones.

How?

By adding a labeler GitHub action that checks the path of the files affected by the PRs.

Testing Instructions

I've created a PoC in a test repository, and it seems to work fine!

@priethor priethor added the [Type] Project Management Meta-issues related to project management of Gutenberg label Jul 18, 2023
@priethor priethor self-assigned this Jul 18, 2023

"[Package] A11y":
- packages/a11y/**
#"[Package] ":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some packages don't have an associated label. This is direct to solve, and labels should be created later for these packages, but I didn't want to interfere with the WIP audit in #52583.

@github-actions
Copy link

Flaky tests detected in 9973baa.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5587437804
📝 Reported issues:

Copy link
Contributor

@jordesign jordesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's beyond my skillset to comment on the code itself - but in terms of the labels being added it looks good to me

@priethor
Copy link
Contributor Author

Thanks for taking a look, @jordesign . There are some label mismatches between the current labels and packages, as I noted in the spreadsheet from #52583. Since package labels should be a direct 1:1 mapping, I will move forward to updating them if you don't mind.

@priethor priethor requested a review from apeatling July 19, 2023 16:09
Copy link
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and should help the problem quite a bit. Looks thorough to me but I will hold off on approval until you have the label mismatches sorted.

@afercia
Copy link
Contributor

afercia commented Sep 4, 2023

Slightly unrelated and maybe it would have been better addressed in the contrext of #52583

I just noticed that there's no label for the existing package @wordpress/customize-widgets.
I'm not sure what the state of this package is, but it seems to me the lack of a label is inconsistent with the similar package @wordpress/edit-widgets which does have its own label: [Package] Edit Widgets.

Actual use case: I'd need the missing label to be added to #54148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants