Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footnotes: backport core changes to excerpt trim #52709

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Footnotes: backport core changes to excerpt trim #52709

merged 1 commit into from
Jul 18, 2023

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jul 18, 2023 •
edited
Loading

What?

A preg_replace to remove footnote anchors was introduced in:

The changes were backported to Core in WordPress/wordpress-develop#4845 with some modifications.

This PR syncs those modifications in the plugin.

Why?

Keep things up to date!

Testing Instructions

There should be no regressions from #52518

  1. Create a post with some footnotes
  2. In the site editor, check the template where your latest posts are displayed. Ensure the footnotes marker (the numbers, like 1, 2, do not appear in the excerpt).
  3. Check the frontend as well.

@ramonjd ramonjd added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Block] Footnotes Affects the Footnotes Block labels Jul 18, 2023
@ramonjd ramonjd requested a review from mcsf July 18, 2023 00:34
@ramonjd ramonjd self-assigned this Jul 18, 2023
@ramonjd ramonjd force-pushed the update/backport-footnote-trim-from-core branch from 74337ee to fcffad8 Compare July 18, 2023 01:00
@github-actions
Copy link

github-actions bot commented Jul 18, 2023 •
edited
Loading

Flaky tests detected in fcffad8.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5582109050
📝 Reported issues:

andrewserong
andrewserong approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for backporting the backport!

✅ Code change looks good
✅ Footnotes are still stripped from excerpt previews in the site editor
✅ Footnotes are still stripped from excerpts on the site frontend
✅ Footnotes are still output at the individual post level

LGTM! ✨

@ramonjd ramonjd enabled auto-merge (squash) July 18, 2023 02:56
@ramonjd ramonjd merged commit 605e718 into trunk Jul 18, 2023
48 checks passed
@ramonjd ramonjd deleted the update/backport-footnote-trim-from-core branch July 18, 2023 03:02
@github-actions github-actions bot added this to the Gutenberg 16.3 milestone Jul 18, 2023
@mburridge mburridge added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 18, 2023
@mcsf
Copy link
Contributor

mcsf commented Jul 18, 2023

Thank you! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewserong andrewserong andrewserong approved these changes

@mcsf mcsf Awaiting requested review from mcsf

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@ramonjd ramonjd

Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Block] Footnotes Affects the Footnotes Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 16.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ramonjd @mcsf @andrewserong @mburridge