-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove footnote from RichText toolbar if already present #52504
Conversation
Size Change: +20 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
Flaky tests detected in 094b137. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5519007809
|
See alternative #52506, which is currently my favourite. |
Closing in favour of #52506 |
What?
Previously, clicking on the Footnote inline format in the RichText toolbar would always insert a new footnote, even if a footnote was already selected. With this pull request, footnotes behave like other formats, which means that the format button acts as a toggle:
Before
footnotes-toggle-format--before.mov
After
footnotes-toggle-format--after.mov
How?
As I understand it, footnotes are a slightly different RichText format. They aren't just a simple inline format, but a special object with a replacement. Notice how most formats are added with
applyFormat
/toggleFormat
, while for footnotes we resort toinsertObject
. So my answer was to just remove the piece of RichText corresponding to the active object. I hope this is the right approach.Testing Instructions