Edit Site: Fix the pattern with the post types becomes the placeholder pattern when editing template part

[arthur791004]

What?

The pattern with the post types becomes the placeholder pattern since the site editor only allows patterns with the specific post type. However, the allowed post type is always undefined because we never pass the value when calling the hook.

Why?

This resolves Automattic/wp-calypso#79145 that the pattern with wp_template_part post type becomes the placeholder pattern when you're editing the template part and you cannot do anything on the placeholder pattern.

How?

The useSiteEditorSettings hook supports templateType as an argument, just pass the value to it so it can filter the patterns out with the specific post type correctly.

Testing Instructions

1. Download TT3 from https://wordpress.org/themes/twentytwentythree/
2. Edit the patterns/footer-default.php pattern as followed

   /**
    * Title: Default Footer
    * Slug: twentytwentythree/footer-default
    * Categories: footer
    * Block Types: core/template-part/footer
    * Block Types: core/template-part
+   * Post Types: wp_template, wp_template_part, page
    */

3. Zip the modified TT3 theme and upload again
4. Go to the site editor to edit the footer template part
5. Before this patch, you will see the placeholder pattern and you cannot do anything on it
6. After this patch, the footer template part will be displayed correctly

Testing Instructions for Keyboard

Screenshots or screencast

Before	After

[okmttdhr]

I did not have time to test, but the code looks good 👍
Thank you for your quick fix.

[okmttdhr]

It might be better to have one more person to review, but let me know if you need to merge.

[getdave]

Rather than dd a dependency to the hook why not select the template type within the hook itself?

const { templateType } = useSelect( ( select ) => {
		const { getEditedPostType } = unlock( select( editSiteStore ) );

		return {
			templateType: getEditedPostType(),
		};
	}, [] );

[arthur791004]

@getdave I just want to follow the original design to let callers decide the template type. But I agree with you that we can select the template type inside the hook itself. I've made the change as you suggested, thanks 👍

[getdave]

This looks better now - thanks for amending. Not sure about those test failures though... 😟

[arthur791004]

Seems like the failed tests are flaky as the results are different after re-triggering 😓

[getdave]

@arthur791004 You'll want to rebase as opposed to merge. We look to avoid merge commits.

• Pull trunk from your upstream (as it looks like you are working on a fork)
• Merge upsteam into your fork's trunk.
• Switch to this branch
• git rebase trunk

[arthur791004]

Okay!

[arthur791004]

@getdave The tests are passed now!

[getdave]

LGTM - this will need backporting so pinging @tellthemachines and @ramonjd

[ramonjd]

Tested and works as described 👍🏻

[tellthemachines]

I just cherry-picked this PR to the update/first-batch-pre-RC1 branch to get it included in the next release: 298f5b1

[arthur791004]

Thank you 😊