Restore @wordpress/nux to WP 6.2 branch
#52452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 58cd4bc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5514002193
|
peterwilsoncc
force-pushed
the
do/restore-nux-wp62
branch
from
4c3b909 to
a361c2f
Compare
This was referenced Jul 10, 2023
|
Local test results on this branch: Seeing some failures on playwright but they match on both this branch and |
peterwilsoncc
force-pushed
the
do/restore-nux-wp62
branch
2 times, most recently
from
55a3f02 to
58cd4bc
Compare
|
Seeing pretty much the same failures on a null pr (adding a temp file) #52492 so calling this ready for review. |
peterwilsoncc
requested review from
spacedmonkey,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
tellthemachines
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts #46110 in the WordPress 6.2 branch. See #52444.
See also:
@wordpress/nuxto WP 6.3 branch #52454 -- Equivalent for WP 6.3 branch@wordpress/nuxto trunk #52455 -- Equivalent for trunkWhy?
As the WordPress-Develop is still consuming the package, this is causing significant issues while running npm run sync-gutenberg-packages for both the wp-6.2 and wp-6.3 distribution tags.
While the script is apparently successful, the incorrect versions of key packages are installed. @wordpress/components reverts to version 23.9.0; @wordpress/data reverts to 8.6.0.
Tagging @wordpress/nux@6.0.0 with the affected distribution tags has been attempted without success, see WP#57643 (comment).
How?
Testing Instructions
npm igit checkout package-lock.jsonif requirednpm distclean; npm clean:packagespackages/nuxdon't existnpm buildpackages/nuxhave been createdLerna dry run: TBA
Testing Instructions for Keyboard
N/A -- code change only
Screenshots or screencast