Improve the Interactivity API priority levels logic #52323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Arenas <david.arenas@automattic.com>
luisherranz
added
[Type] Experimental
|
Size Change: +928 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 228a940. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5621696014
|
|
@DAreRodz and I have spent more time on this. We're going to leave the The logic was mostly working, tho. We just have to create new references for the const NextDirectives = useMemo(() => {
const Comp = Directives.bind();
Comp.displayName = `Directives - ${Object.keys(
thisPriorityLevel
).join(", ")}`;
return Comp;
}, []);
// ...
const children =
restPriorityLevels.length > 0 ? (
<NextDirectives
// ...
We still need to do it for the root |
luisherranz
changed the title
|
This should be ready for review now. |
luisherranz
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad,
ajitbohra and
DAreRodz
as code owners
DAreRodz
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
I think it's a great refactoring (given that I have contributed, haha 😅). Approved! ✅
PS: This is just nitpicking; I would have changed thisPriorityLevel with currentPriorityLevel, and restPriorityLevel with nextPriorityLevel. As the Directive component is iterating through all the priority levels, I feel those names are easier to understand. But there's not need to change them―it's just a feeling. 🤷
I like that. I'll change it before merging. |
8 tasks
If I'm not mistaken, |
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@DAreRodz and I have been trying to improve the logic of the priority levels implementation.
Why?
Because we wanted to remove the
Directivetop-level component and leave only components for each priority level and also improve the overall logic:Directivecomponent.ref(it's broken now).Directivescomponent if none of the directives present in the element are registered.See ifcloneElementis still necessary.See if the recursiveness can be absorbed in theoptions.vnodehook. Not important unless we can reduce the code size.We left these tasks for later:
Directives: bind, class.How?
So far, we moved the
Directivecomponent logic to theoptions.vnodehook. We still need to fix theref, but the tests are passing (we need tests that break theref, probably withwp-show).