Prevent scripts from loading if behaviors are not used #52140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalczaplinski
added
[Type] Enhancement
69 tasks
|
Flaky tests detected in c15fbe4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5520312218
|
michalczaplinski
requested review from
artemiomorales and
SantosGuillamot
and removed request for
ajitbohra
13 tasks
artemiomorales
requested changes
Jul 4, 2023
There was a problem hiding this comment.
Hi @michalczaplinski! I took a look and this PR works if the theme.json default value for the behavior is false, but it breaks the lightbox if the default value is true. To Illustrate further:
This works
"behaviors": {
"blocks": {
"core/image": {
"lightbox": {
"enabled": false
}
}
}
}
This doesn't work
"behaviors": {
"blocks": {
"core/image": {
"lightbox": {
"enabled": true
}
}
}
}
- Copy the logic from behaviors.php
There was a problem hiding this comment.
@michalczaplinski As I think on it, I believe we should also add a test for this.
|
Some quick comments on code & tests: 2023-07-11_14-08-25.mp4 |
|
Size Change: +2.41 kB (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
@michalczaplinski It's working — looking good! I think we should also add the following test cases:
-Should add view script if lightbox is enabled via theme.json
-Should NOT add view script if lightbox is enabled via theme.json but overriden in block settings
artemiomorales
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
@michalczaplinski I've added the additional test cases. Let me know if all looks good to you! If so, I think we can merge.
cbravobernal
approved these changes
Jul 18, 2023
|
Looks good, thanks for adding the extra tests @artemiomorales ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When no behaviors are used, do not load the
interactivity-view.jsfile.Why?
So that we don't wastefully load JS.
How?
Adding a workaround very similar to the one currently used in the Navigation block.
Testing Instructions
interactivity-view.jsfile is not loaded.Lightboxbehavior and save the post.