Force full height for editor in Navigation focus mode #51798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
Size Change: +1 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Fixes #51792 |
|
cc @jasmussen and @mtias who I think will have opinons. |
scruffian
approved these changes
Jun 23, 2023
scruffian
force-pushed
the
update/full-height-nav-focus-mode
branch
from
d42863a
to
6fb6a85
Compare
|
Seems fine to me. There are still some open questions around this particular mode, but none that need block this. Thanks! |
|
I do have opinions :) — I think this is very confusing. We should be going the opposite way and ensuring the frame and canvas have the height that the pattern needs, and never force full height. I understand detached menus can be a bit more tricky. |
Unfortunately (as you acknowledged) it's not so simple for Navigations because we have submenus. It's a far worse UX when you can't actually edit the menu because it is clipped by the canvas. Thus why we decided it ws important to land this "fix". Every other focus mode remains "as is" though so that's ok. If anyone from design has any good ideas for how we can solve this UX conundrum I'm happy to work on it in the 6.4 cycle. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes Navigation focus mode use full height editor
Why?
When editing Navigations with submenus the dropdowns would be clipped by the height of the focus mode which was previously set to be the height of the block itself.
We need to allow full editing and there is no real downside to allowing this.
How?
Adds a condition to force full height for Navigation Focus mode.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast