Update Library panel footer #51652
Merged
Update Library panel footer #51652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
the
[Feature] Site Editor
jasmussen
approved these changes
Jun 19, 2023
| @@ -40,7 +40,7 @@ const config = { | |||
| title: __( 'Library' ), | |||
| loading: __( 'Loading library' ), | |||
| notFound: __( 'No patterns found' ), | |||
| manage: __( 'Manage all template parts' ), | |||
| manage: __( 'Manage template parts' ), | |||
There was a problem hiding this comment.
I like shorter, but since you're already seeing TPs in the library, is this actually clearer? Not a strong opinion, but why would I want to click "Manage template parts" if I can already see them?
There was a problem hiding this comment.
Hmm good point.
I suppose it depends how you read it. For me the onus is on 'manage' rather than 'all'. So to answer your question: you'd click if you want to manage what you can see. IE quickly delete / rename a bunch of template parts. From that perspective 'all' is kind of implied – you wouldn't jump directly into managing only a portion of template parts.
That said, I notice we currently have "Manage all templates" in the Templates panel 🙈 So perhaps we leave this one change out for now.
|
Size Change: +8 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4ec3915. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5312371165
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Update button, add radius * Manage template parts * Reinstate 'all'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates a few details in the Library panel footer:
Why?
Testing Instructions