Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance tests: update base point to compare #51381

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Performance tests: update base point to compare #51381

merged 1 commit into from
Jun 9, 2023

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Jun 9, 2023 •
edited
Loading

What?

Update the base commit we use in the performance tests. For each WordPress release, we need to update this commit.

Why?

We need a commit that is compatible with the current WP version.

How?

Took the latest commit in the wp/6.2 branch, 843a305

@oandregal oandregal requested a review from youknowriad June 9, 2023 14:16
@oandregal oandregal self-assigned this Jun 9, 2023
@oandregal oandregal added the [Type] Performance Related to performance efforts label Jun 9, 2023
@oandregal
Use the latest commit from the wp/6.2 branch
1387eb8 
We cannot use the wp/6.2 as an alias. The reason is that the branch
is updated for minor and security releases as well (6.2.1, 6.2.2, etc.).
@oandregal oandregal force-pushed the try/perf-tests-to-use-wp-major-sha branch from 7c4e959 to 1387eb8 Compare June 9, 2023 14:41
@oandregal oandregal marked this pull request as ready for review June 9, 2023 14:47
@github-actions
Copy link

github-actions bot commented Jun 9, 2023 •
edited
Loading

Flaky tests detected in 1387eb8.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5223095210
📝 Reported issues:

@oandregal oandregal merged commit 8db07c1 into trunk Jun 9, 2023
@oandregal oandregal deleted the try/perf-tests-to-use-wp-major-sha branch June 9, 2023 15:45
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 9, 2023
@oandregal oandregal mentioned this pull request Jun 9, 2023
Merged
@t-hamano t-hamano mentioned this pull request Jun 12, 2023
Merged
@youknowriad youknowriad mentioned this pull request Jun 20, 2023
Merged
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@oandregal @sethrubenstein
Performance tests: update base point for 6.2 (WordPress#51381)
e4cd9b8 
We cannot use the wp/6.2 alias. The reason is that the branch is updated for minor and security releases as well (6.2.1, 6.2.2, etc.), so it's a moving target.
@Mamaduka Mamaduka mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees

@oandregal oandregal

Labels
[Type] Performance Related to performance efforts
Projects
None yet
Milestone
Gutenberg 16.1
Development

Successfully merging this pull request may close these issues.
2 participants
@oandregal @youknowriad