Widget Editor: Update settings icon #51029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -178 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
|
Flaky tests detected in c1aea20. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5098349708
|
talldan
approved these changes
May 29, 2023
|
Thanks for the review, @talldan! |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the settings icon in the Widget Block Editor.
Why?
As part of #45005, the settings icons in the post editor and site editor have been updated. (from
cogtodrawerLeft|drawerRight). I believe that the widget editor icon should also be updated to maintain consistency in the UI.Meanwhile, we need to continue to discuss #46851, which proposes reverting this icon back to the previous gear icon.
Testing Instructions
If the language of the site is RTL language, make sure that the icons are also reversed left to right.