Add Block-editor-keyboard-shortcut test case #50930
Conversation
alvitazwar
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
|
Hey there! I wanted to express my gratitude for the PR you submitted. By the way, have you had a chance to check out the latest best practices guide? It's packed with some really helpful tips and tricks that can make a big difference in how we write reliable and readable e2e tests. One key suggestion is to make good use of the |
|
@kevin940726 Can you please recheck that for me? |
|
Hi @alvitazwar! I've been busy with something else recently, but this is still on my backlog! I'll get back to it as soon as possible 🙇 . |
skorasaurus
added
the
[Type] Automated Testing
There was a problem hiding this comment.
The PR removes the specs/editor/various/autosave.test.js file instead of the block-editor-keyboard-shortcuts.test.js.
Additional notes:
- I'm not sure if
await expect.poll( editor.getEditedPostContent ).toBe( MatchObject );assertions check anything related to keyboard navigation. - Let's combine two
test.describeinto one. The grouping usually makes it harder to know where the new tests go. I think it's better to split tests into multiple files if there's a need for a separate test group.
| await page.keyboard.type( '3rd' ); | ||
| await expect.poll( editor.getEditedPostContent ).toBe( MatchObject ); | ||
| await page.keyboard.press( 'ArrowUp' ); | ||
| page.locator( '[aria-label="Multiple selected blocks"]' ); |
There was a problem hiding this comment.
Call the just the locator doesn't do anything. This should be converted into a proper assertion.
github-actions
bot
added
the
[Status] In Progress
What?
Based on #38570, part of #38851. Migrate block-editor-keyboard-shortcuts.test.js
Why?
See #38570 for its background and rationale.
This is split into a new PR for easier review.
How?
See #38570 for the proposed migration steps.
Testing Instructions
npm run test:e2e:playwright /test/e2e/specs/editor/various/block-editor-keyboard-shortcuts.spec.js
Screenshots or screencast
Screen.Recording.2023-05-25.at.12.21.20.AM.mov