Fix custom template creation regression #50797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Regression
|
Size Change: +68 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in aa0aa39. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5044227482
|
|
Here's a GIF showing the behavior:
One thing we know we'll want in the future is to animate these modals when they change size. And size is the main problem with the second step, the custom template. If it was just sized appropriately it'd be fine. |
ntsekouras
commented
May 22, 2023
| @@ -50,7 +50,7 @@ function AddCustomGenericTemplateModalContent( { onClose, createTemplate } ) { | |||
| placeholder={ defaultTitle } | |||
| disabled={ isBusy } | |||
| help={ __( | |||
| 'Describe the template, e.g. "Post with sidebar".' | |||
| 'Describe the template, e.g. "Post with sidebar". A custom template can be manually applied to any post or page.' | |||
There was a problem hiding this comment.
This is just to match the post editor's modal.
@jasmussen I have made the input in the modal to be full width for now. We should probably land this regression and have a follow up for design improvements, as it's not working right now on trunk. What do you think? |
kevin940726
reviewed
May 22, 2023
jameskoster
approved these changes
May 22, 2023
|
The input becomes a bit wide, so it'd be good to follow up. |
|
I'll make an issue for the UX / Polish board when I get a moment 👍 Edit: No need, already tracked in #50395. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #50793
I introduce a regression in #50595 where the creation of a custom template is not possible right now. This PR fixes that.
Since it seems we focuses on the other flows mostly, this might need some css tweaks or design feedback