Library: Rename template parts to library #50769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds link to reusable blocks admin.
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +22.3 kB (+2%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
May 19, 2023
packages/edit-site/src/components/sidebar-navigation-screen-templates/index.js
Outdated
Show resolved
Hide resolved
kevin940726
approved these changes
May 19, 2023
There was a problem hiding this comment.
LGTM 👍 !
Note that the template parts page is still showing "All template parts" rather than what the link suggests ("Manage all patterns"). This could be a source of confusion for the users. We can merge this and quickly iterate to other planned features mentioned in the issue though, so I don't think it's a blocker. Or we could also put these behind a feature flag, I don't mind either 👍 .
|
Thanks for the review and the updates @kevin940726 🙇
Good point. Perhaps we could just revert the renaming of that link temporarily so it still reads "Manage all template parts" which matches the page it will go to. Also, taking another look at the design direction, that "Manage all" link will likely be removed when we update the page to include reusable blocks and display everything as a grid. I'll revert that link text and get this merged. |
|
Flaky tests detected in bb27f0d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5040890790
|
aaronrobertshaw
deleted the
try/renaming-template-parts-nav-items-to-library
branch
|
I know this is already merged, but copy ideas for the future: "Manage the patterns that are available when editing your site." Are there ways to add copy to differentiate why the patterns here, in this context, are different than the patterns someone sees in the Editor's Pattern Inserter? |
|
Thanks for the suggestion and question @autumnfjeld 👍 This was just the very tip of changes to overhauling pattern, template part, and reusable block, management. The Library section of the site editor is in the process of getting some major updates which you can get a glimpse of in #50028 (comment). Some exploratory work is ongoing in #51078 but is likely to change drastically in the near future. These efforts will also combine with work being done on patterns to offer different levels of syncing, unify patterns with reusable blocks etc. When all this comes together I believe that the differentiation you refer won't really be present or at least not to a level that requires a user-facing explanation. Also, the description text was reverted in #51039 given the time it was going to take to iterate on the Library. |
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Renames the primary template part navigation items in the site editor and adds a link off to the reusable blocks admin.
Why?
This is a small step towards the new "Library" to manage all things patterns, reusable blocks, template parts etc.
How?
Testing Instructions
Screenshots or screencast