[RNMobile] Disable regular blocks conversion if the reusable block is empty #50475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted blocks doesn't have inner blocks, so we can rely on inner block count to determine if the conversion can happen.
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
|
Flaky tests detected in aad7f0e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4927973702
|
derekblank
approved these changes
May 10, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#5723.
What?
Disables the option for converting to regular blocks a deleted reusable block in order to prevent an exception.
Why?
This PR addresses a crash we have in the app: wordpress-mobile/gutenberg-mobile#5723.
How?
We check the inner blocks count to determine if the conversion option should be displayed.
Testing Instructions
Conversion option is not displayed on deleted reusable blocks
NOTE: The above steps are the same as outlined in the issue being solved: wordpress-mobile/gutenberg-mobile#5723.
Conversion option is displayed for regular reusable blocks
Testing Instructions for Keyboard
N/A
Screenshots or screencast