Fixes focus managemnt on block selection change for fixed block toolbar #50346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +35 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
@draganescu, do we want to maintain the I am asking because I might have an alternative fix for this. |
The problem here was that we also manually handle focus on the expand/collapse controls and that was stealing the focus away from the block when you selected a new one. If we can improve my approach I am all for it - using yet another state smells a bit like not the best way, but I haven't found a more streamlined approach. |
This was referenced May 9, 2023
|
This works but #50497 is much cleaner and also does a good refactoring in the new block toolbar code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #50337
Why?
Because clicking on a block should keep focus on the clicked block.
How?
Adds a new state to the block toolbar that tracks block selection change. We need a new state because we need to konw that the selection changed between renders of the block toolbar inside the block contextual toolbar which is only mounted once.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
top-toolbar-focus-block-selection.mp4