Footnotes stored in the FN block #50124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.06 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
ellatrix
commented
May 2, 2023
| reducer | ||
| ); | ||
|
|
||
| return filteredState; |
There was a problem hiding this comment.
I know this is not great, but the footnotes block needs to be able to create a higher order reducer so it can react to state changes without making new undo levels. Maybe we can find an alternative API, or maybe even create this block (and format) in the block-editor package.
ellatrix
commented
May 2, 2023
| ( block ) => block.name === 'core/post-content' | ||
| ); | ||
| return reducer( state, { | ||
| type: 'INSERT_BLOCKS', |
There was a problem hiding this comment.
I'd be great if the block has access to the raw actions.
There was a problem hiding this comment.
I think blocks should never have access to state format or raw actions because these changes we evolve often for performance reasons... That said, for this specific case, it could be a private API.
ellatrix
requested review from
fluiddot,
dcalhoun,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
ellatrix
changed the title
ellatrix
changed the title
|
This is causing elements that happen to have the .fn {
counter-increment: footnotes;
display: inline-block;
font-size: smaller;
text-indent: -9999999px;
vertical-align: super
}
.fn:after {
content: "[" counter(footnotes) "]";
float: left;
text-indent: 0
}The CSS selector will need to be more specific so this does not negatively affect user site content. |
|
We went for post meta: #51201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Previously: #49797, #47682, #28261, #15267.
This PR explores saving footnotes in a footnotes block. This means no PHP processing is needed. It's done by checking state updates and re-ordering, adding, or removing footnotes in the block when needed, through a HoR (Higher-order Reducer).
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast