Cover: Only show overlay controls when color support enabled #50115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: -1.52 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
aaronrobertshaw
commented
Apr 27, 2023
Comment on lines
+64
to
+69
| }, [ | ||
| defaultColors, | ||
| themeColors, | ||
| customColors, | ||
| shouldDisplayDefaultColors, | ||
| ] ); |
There was a problem hiding this comment.
Added missing dep to keep linter happy.
Comment on lines
+111
to
+116
| }, [ | ||
| customGradients, | ||
| themeGradients, | ||
| defaultGradients, | ||
| shouldDisplayDefaultGradients, | ||
| ] ); |
There was a problem hiding this comment.
Added missing dep to keep linter happy.
Comment on lines
20
to
48
| jest.mock( | ||
| '@wordpress/block-editor/src/components/colors-gradients/use-multiple-origin-colors-and-gradients', | ||
| () => ( { | ||
| __esModule: true, | ||
| default: jest.fn( () => ( { | ||
| disableCustomColors: true, | ||
| disableCustomGradients: true, | ||
| colors: [ | ||
| { | ||
| name: 'Default', | ||
| colors: [ | ||
| { | ||
| name: 'Black', | ||
| slug: 'black', | ||
| color: '#000000', | ||
| }, | ||
| { | ||
| name: 'Cyan bluish gray', | ||
| slug: 'cyan-bluish-gray', | ||
| color: '#abb8c3', | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| gradients: [], | ||
| hasColorsOrGradients: true, | ||
| } ) ), | ||
| } ) | ||
| ); |
There was a problem hiding this comment.
I'll try and clean this up tomorrow.
There was a problem hiding this comment.
I've avoided mocking the useMultipleOriginColorsAndGradients hook in favour of setting explicit editor settings in bbac907. I'm not 100% confident in that approach either so happy to change it if others have suggestions.
There was a problem hiding this comment.
The new approach matches the actual editor's behavior.
Mamaduka
approved these changes
Apr 28, 2023
aaronrobertshaw
deleted the
try/hide-cover-overlay-controls-when-colors-disabled
branch
This was referenced May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50046
What?
Prevents display of overlay controls when color block supports are disabled.
Why?
It's confusing when a theme author might disable color supports but still has the Cover block's ad hoc color controls showing.
How?
hasColorsOrGradientsto returned object from theuseMultipleOriginColorsAndGradientshookTesting Instructions
npm run test:unit packages/block-library/src/cover/test/edit.jsTheme.json to disable color support
Screenshots or screencast