-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CardMedia: Improve docs #50074
CardMedia: Improve docs #50074
Conversation
Hi @mirka, thanks for this PR. I've tried testing it with
Even though the directory is most definitely there. Any idea what gives? Is there something I'm missing? |
Here's some additional output from the command in case it helps: npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! gutenberg@15.6.2 storybook:dev: `concurrently "npm run dev:packages" "start-storybook -c ./storybook -p 50240"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the gutenberg@15.6.2 storybook:dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above. |
@mburridge Thanks for testing! Does it work on trunk for you? You might want to try running |
No, I get the same problem on trunk.
I used a fresh clone of the repo, but tried running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got it working 🙌! LGTM.
Closes #39830
What?
Improve the docs/stories for the CardMedia component so it's clearer that it's more of a generic full-bleed container, rather than a container for "media".
Why?
It's hard to discover that this component can be used for this purpose.
Testing Instructions
npm run storybook:dev
and see the new story (?path=/docs/components-card--full-bleed-content
) for theCard
component. Check that it is understandable.