-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain context when opening modals on small screens #50039
Conversation
If we don't feel that retaining context is important, the simpler alternative would be to remove the |
Size Change: +17 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda love it:
I think the only question is whether we'll ever actually want a separate modal "sheet" component that isn't the default modal component. But I don't think that needs to block this, so mainly for information, CC: @ciampo
Nice new Changelog test. Looks like you need to update the components/CHANGELOG.md file with a small snippet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
@jasmussen Happy to discuss further if/when it's necessary! |
What?
Updates the modal appearance on small screens to resemble a 'sheet' pattern commonly found in design systems.
Why?
How?
CSS adjustments. I also applied the 'slide up' animation to the small screen styles to underline the sheet behavior.
Testing Instructions
Before
After
mobile-modal.mp4