Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update frame resizing #49910

Merged
merged 35 commits into from
May 19, 2023
Merged

Update frame resizing #49910

merged 35 commits into from
May 19, 2023

Commits on May 19, 2023

  1. frame resizer centered

    @SaxonF @ciampo
    SaxonF authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    8e9c1af View commit details
    Browse the repository at this point in the history

  2. Use a lerp function to modify the height of the frame. 

    It should gradually reduce from original aspect ratio
until reaching a 9 / 19.5 view.
    @mtias @ciampo
    mtias authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    0441dba View commit details
    Browse the repository at this point in the history

  3. Make the frame full screen when the user resizes it to the left. 

    Reset the initial aspect ratio if the frame is resized slightly,
and trigger full screen if the frame is resized far enough over the sidebar.
    @mtias @ciampo
    mtias authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    43019aa View commit details
    Browse the repository at this point in the history

  4. Ensure the frame grows only to the left when going above its size.

    @mtias @ciampo
    mtias authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    63e5509 View commit details
    Browse the repository at this point in the history

  5. Disable user selection while resizing the frame.

    @mtias @ciampo
    mtias authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    77d55c4 View commit details
    Browse the repository at this point in the history

  6. Make it easier to grab the handle.

    @mtias @ciampo
    mtias authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b08b57a View commit details
    Browse the repository at this point in the history

  7. Switch to setTimeout and set a fixed resizeRatio.

    @mtias @ciampo
    mtias authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    17becce View commit details
    Browse the repository at this point in the history

  8. Modify oversized calculation to reduce resizing bug.

    @mtias @ciampo
    mtias authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    59bfa2f View commit details
    Browse the repository at this point in the history

  9. Avoid timer

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    d8dd107 View commit details
    Browse the repository at this point in the history

  10. Temp working

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    6322c3c View commit details
    Browse the repository at this point in the history

  11. Clean up CSS

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    1934811 View commit details
    Browse the repository at this point in the history

  12. More cleanup

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    dbb51f9 View commit details
    Browse the repository at this point in the history

  13. Refactor lerpy parts

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    05c49fc View commit details
    Browse the repository at this point in the history

  14. More cleanup

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    dc89a28 View commit details
    Browse the repository at this point in the history

  15. Rename isFull to isFullWidth

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    0d19489 View commit details
    Browse the repository at this point in the history

  16. Improve maintainability

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    602e612 View commit details
    Browse the repository at this point in the history

  17. More cleanup

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    bdc1732 View commit details
    Browse the repository at this point in the history

  18. Match component classnames

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    34ccb00 View commit details
    Browse the repository at this point in the history

  19. Invert control for flex changes

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    0a2cb41 View commit details
    Browse the repository at this point in the history

  20. Calculate fluid resize ratio

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b69ee87 View commit details
    Browse the repository at this point in the history

  21. Prevent React re-render loop warning

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    3bb9c10 View commit details
    Browse the repository at this point in the history

  22. Always show handle when resizing

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    3ef1855 View commit details
    Browse the repository at this point in the history

  23. Maintain resizing cursor when resizing

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    a742569 View commit details
    Browse the repository at this point in the history

  24. Improve code comments

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    48658ca View commit details
    Browse the repository at this point in the history

  25. Exclude ListPage from ResizableFrame

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    cd5bcc4 View commit details
    Browse the repository at this point in the history

  26. Use CSS var for accent color

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    09bc6fd View commit details
    Browse the repository at this point in the history

  27. Handle spinner gracefully

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    d518f0e View commit details
    Browse the repository at this point in the history

  28. Lift loading state so resizing can be disabled

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    ee461b9 View commit details
    Browse the repository at this point in the history

  29. Change max width for less jankiness

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b85a344 View commit details
    Browse the repository at this point in the history

  30. Remove outdated padding animation

    @mirka @ciampo
    mirka authored and ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    334b643 View commit details
    Browse the repository at this point in the history

  31. Clean up magic numbers

    @ciampo
    ciampo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    44828f7 View commit details
    Browse the repository at this point in the history

  32. Update saveSiteEditorEntities() locators

    @WunderBart
    WunderBart committed May 19, 2023
    Configuration menu
    Copy the full SHA
    db6330c View commit details
    Browse the repository at this point in the history

  33. Update StyleBook.open() locators

    @WunderBart
    WunderBart committed May 19, 2023
    Configuration menu
    Copy the full SHA
    929e903 View commit details
    Browse the repository at this point in the history

  34. Quickfix: Wait until load spinner is gone

    @mirka
    mirka committed May 19, 2023
    Configuration menu
    Copy the full SHA
    5d53981 View commit details
    Browse the repository at this point in the history

  35. Revert to class-based save detection 

    The `.getByRole()` way resolves a bit too early.
    @mirka
    mirka committed May 19, 2023
    Configuration menu
    Copy the full SHA
    a2bf020 View commit details
    Browse the repository at this point in the history