Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix centering #4970

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Fix centering #4970

merged 1 commit into from
Feb 9, 2018

Conversation

jasmussen
Copy link
Contributor

This fixes an issue where an un-resized but still not full-width image wouldn't center in the editor.

It also removes some CSS bleed for some alignment styles that were specific to the Classic block, but weren't necessary for Gutenblocks. This fixes #4968.

Editor centered images, before:

screen shot 2018-02-09 at 07 45 04

After:

screen shot 2018-02-09 at 07 51 15

Alignment styles scoped to classic block:

screen shot 2018-02-09 at 08 00 55

This fixes an issue where an un-resized but still not full-width image wouldn't center in the editor.

It also removes some CSS bleed for some alignment styles that were specific to the Classic block, but weren't necessary for Gutenblocks. This fixes #4968.
@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label Feb 9, 2018
@jasmussen jasmussen self-assigned this Feb 9, 2018
@jasmussen jasmussen requested a review from karmatosed February 9, 2018 07:03
@jasmussen jasmussen merged commit 98d6c7e into master Feb 9, 2018
@jasmussen jasmussen deleted the try/fix-centering branch February 9, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery Block: Align center adds 'display: block' in editor, breaking flexbox
2 participants