-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Update Sandbox component #49663
Conversation
( message ) => { | ||
let data = message?.nativeEvent?.data; | ||
|
||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I omitted the existing string check. The try is robust enough to handle non strings.
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
Flaky tests detected in 43ef2da. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4639706150
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
I followed the testing instructions from Automattic/jetpack#29990 and confirmed that worked as expected. Similarly, I tested the Embed block using different providers and didn't find any regressions.
I added some minor comments but none should be considered blockers.
Follow testing instructions on
Verify that native embed blocks are performing as expected
What?
Adds the following enhancements to the native
Sandbox
component:WebView
component to allow the parent component to inject javascriptWebView
window
Why?
WebView
methods e.g. injecting JavaScript after the component has mountedwindow
eventsHow?
forwardRef
callonWindowEvents
which accepts an object of the form{ 'event_type' : eventHandlerFunction }
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast