Lodash: Remove _.mapValues() from various blocks
#49637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: +57 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
sgomes
approved these changes
Apr 6, 2023
| return toWidthPrecision( newWidth ); | ||
| } ); | ||
| return Object.fromEntries( | ||
| Object.entries( getColumnWidths( blocks, totalBlockCount ) ).map( |
There was a problem hiding this comment.
Note: getColumnWidths will always return an object, assuming it doesn't throw.
| if ( selectionRowIndex && selectionRowIndex !== rowIndex ) { | ||
| return row; | ||
| return Object.fromEntries( | ||
| Object.entries( tableSections ).map( ( [ sectionName, section ] ) => { |
There was a problem hiding this comment.
Note: tableSections will always be an object at this point.
|
Thanks for double-checking for errors, @sgomes! I've just added a last-minute fix to actually properly clean up nested object values. |
|
Flaky tests detected in ec78782. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4629860693
|
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.mapValues()from a few of the core blocks.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Object.fromEntries( Object.entries().map() )as a replacement, with nullish coalescing to an empty object when the input may not be declared.Much of the PR is actually whitespace, so you could review it easier by disabling whitespace.
Testing Instructions
textDecoration: strikethroughtypography setting set is properly being migrated toline-through.