-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles: Update Block specific CSS label to include additional instructions. #49626
Global Styles: Update Block specific CSS label to include additional instructions. #49626
Conversation
I'd be willing to expect the exact wording of the additional text could be reviewed and improved. |
Adding needs copy review as I agree that this could be refined a bit! Thanks for opening either way 💥 |
Sorry—just fixed our Github notification settings, so only seeing this now! Copy looks fine, but if there's any interest, I think we could do a minor tweak:
|
Hello @jordesign! Can we get the "Needs Copy Review" label removed here? This GH issue keeps popping up in our Slack channel and we've satisfied it. (I tried to figure out how to remove the label myself, but I don't seem to have the option of doing so.) Thanks so much! |
@kristastevens - sure can! Sorry about that. |
No worries at all! Thanks so much, friend! |
@jordesign Are you able to rebase this one? If not I can help assuming this is still relevant. |
Hey @apeatling have updated this one - as it turns out the structure/location of that string needed to change anyway since I first issued this PR. Fingers crossed - it should be good to go now. |
Looks good, I'm re-running the tests since they didn't pass and it seems unrelated to this PR. |
@apeatling Looks like it is still failing on some kind of linting error I can't figure out I'm afraid :) |
Turns out it was the double space in the string causing it to fail. Took a little while to track down. 😅 |
Awesome - thanks so much for sorting that out :) |
What?
This PR adds an additional sentence of text to the label for Block specific 'Additional CSS' in the Styles panel (Styles > Block > Paragraph > Additional CSS).
This sentence provides context and instructions for the formatting of the CSS when it is in this mode (specific to a certain block type).
Why?
Addresses part of #49531 - providing additional details of how to use the CSS panel in this context.
How?
Adds an additional bit of information to the label - to guide the user.
Testing Instructions
Screenshots or screencast