Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Update Block specific CSS label to include additional instructions. #49626

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

jordesign
Copy link
Contributor

@jordesign jordesign commented Apr 6, 2023

What?

This PR adds an additional sentence of text to the label for Block specific 'Additional CSS' in the Styles panel (Styles > Block > Paragraph > Additional CSS).

This sentence provides context and instructions for the formatting of the CSS when it is in this mode (specific to a certain block type).

Why?

Addresses part of #49531 - providing additional details of how to use the CSS panel in this context.

How?

Adds an additional bit of information to the label - to guide the user.

Testing Instructions

  1. Open the Site Editor and edit a template
  2. Open the styles panel and go to Blocks > Paragraph (or another block) > Additional CSS.

Screenshots or screencast

Screen Shot 2023-04-06 at 7 20 06 am

@jordesign
Copy link
Contributor Author

I'd be willing to expect the exact wording of the additional text could be reviewed and improved.

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Apr 6, 2023
@annezazu annezazu added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Apr 6, 2023
@annezazu
Copy link
Contributor

annezazu commented Apr 6, 2023

Adding needs copy review as I agree that this could be refined a bit! Thanks for opening either way 💥

@provenself
Copy link

Sorry—just fixed our Github notification settings, so only seeing this now! Copy looks fine, but if there's any interest, I think we could do a minor tweak:

Add your own CSS to customize the appearance of the %s block. You do not need to include a CSS selector, only the property and value.

@kristastevens
Copy link

Hello @jordesign! Can we get the "Needs Copy Review" label removed here? This GH issue keeps popping up in our Slack channel and we've satisfied it. (I tried to figure out how to remove the label myself, but I don't seem to have the option of doing so.) Thanks so much!

@jordesign
Copy link
Contributor Author

@kristastevens - sure can! Sorry about that.

@jordesign jordesign removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Sep 12, 2023
@kristastevens
Copy link

No worries at all! Thanks so much, friend!

@apeatling
Copy link
Contributor

@jordesign Are you able to rebase this one? If not I can help assuming this is still relevant.

@jordesign
Copy link
Contributor Author

Hey @apeatling have updated this one - as it turns out the structure/location of that string needed to change anyway since I first issued this PR.

Fingers crossed - it should be good to go now.

@apeatling
Copy link
Contributor

Looks good, I'm re-running the tests since they didn't pass and it seems unrelated to this PR.

@jordesign
Copy link
Contributor Author

@apeatling Looks like it is still failing on some kind of linting error I can't figure out I'm afraid :)
https://github.com/WordPress/gutenberg/actions/runs/6193057817/job/16834334818?pr=49626

@apeatling
Copy link
Contributor

Turns out it was the double space in the string causing it to fail. Took a little while to track down. 😅

@apeatling apeatling merged commit aeb7be8 into WordPress:trunk Sep 18, 2023
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 18, 2023
@jordesign
Copy link
Contributor Author

Awesome - thanks so much for sorting that out :)

@jordesign jordesign deleted the try_block_css_instructions branch September 25, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants