Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements for the Document Overview labelling #49555

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Small improvements for the Document Overview labelling #49555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bd73e9
Improve document overview labels.
afercia Apr 3, 2023
126afa7
Adjust test.
afercia Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/edit-post/src/components/secondary-sidebar/list-view-sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ export default function ListViewSidebar() {
return (
// eslint-disable-next-line jsx-a11y/no-static-element-interactions
<div
aria-label={ __( 'Document Overview' ) }
className="edit-post-editor__document-overview-panel"
onKeyDown={ closeOnEscape }
ref={ sidebarRef }
Expand All @@ -107,7 +106,7 @@ export default function ListViewSidebar() {
>
<Button
icon={ closeSmall }
label={ __( 'Close Document Overview Sidebar' ) }
label={ __( 'Close' ) }
onClick={ () => setIsListViewOpened( false ) }
/>
<ul>
Expand Down
8 changes: 5 additions & 3 deletions test/e2e/specs/editor/various/list-view.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,11 @@ test.describe( 'List View', () => {
await pageUtils.pressKeys( 'shift+Tab' );
await pageUtils.pressKeys( 'shift+Tab' );
await expect(
editor.canvas.getByRole( 'button', {
name: 'Close Document Overview Sidebar',
} )
editor.canvas
.getByRole( 'region', { name: 'Document Overview' } )
.getByRole( 'button', {
name: 'Close',
} )
).toBeFocused();

// Close List View and ensure it's closed.
Expand Down