Adds top toolbar improvements to site editor #49489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wraps the edit post header in a slot fill provider - implements a temporary behavior that shows document tools when no block is selected - updates the block tools and parent selector to appear properly in the new place
…slot fill provider
- restores fixed toolbar on mobile viewports - adds hover states to toolbar toggles - adds the correct level up icon - moves CSS to the right files Co-authored-by: Joen A. <1204802+jasmussen@users.noreply.github.com> Co-authored-by: James Koster <846565+jameskoster@users.noreply.github.com>
draganescu
changed the base branch from
trunk
to
try/block-tools-marry-document-tools
draganescu
requested review from
jasmussen,
jameskoster,
scruffian,
getdave,
tellthemachines and
aaronrobertshaw
draganescu
added
[Type] Enhancement
|
Size Change: +2.88 kB (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8182479. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4566409911
|
|
Thanks for putting the PR together. It brings #29673 into stark visibility, but even with correct alignment it seems we wouldn't have enough space to accommodate everything nicely on smaller screens. The duplicated template part name is also awkward:
I think this could use some design exploration to get right. |
|
We might want to fade out / hide that center element when a block is selected, at the very least on smaller viewport widths. |
|
That's an option, but if it becomes the way to invoke the Command Center in the full-screen editor as discussed, then it's importance goes up quite a bit, and I'd be a little nervous about hiding it. Perhaps we start with that though, and see how it feels? For the duplicated template part name issue, maybe we hide the one in the center element when top toolbar is enabled? We might be able to remove it altogether in the future. |
I'm thinking of it more as the top toolbar being entirely contextual. Just to visualize across the spectrum:
That includes an in-exploration new document selector as mocked up by @SaxonF. |
So the premise is: because I selected a block, I'm working on that block, and won't want to invoke the command center during that process? That makes sense to me conceptually, but the idea of having to deselect a block before being able to invoke the command center (outside of the keyboard shortcut) seems a little bit unexpected. Especially if we can see per-block commands "make this text sound more formal" being added in the future. Still, probably fine in the short term 👍 |
draganescu
force-pushed
the
try/block-tools-marry-document-tools
branch
from
b85ff40 to
0988ac3
Compare
|
Closed in favor of #49634 which also includes site editor in the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #47277
To make things easier to review this patch applies the top toolbar improvements to the site editor.
site-editor-improved-top-toolbar.mp4