Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSES: Remove the filter that makes filter a safe attribute #49488

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

scruffian
Copy link
Contributor

@scruffian scruffian commented Mar 30, 2023

Warning

Don't merge this until we no longer have to support WordPress 6.2 in Gutenberg.

What?

In #48281 we added a new filter for wp_kses to enable the filter attribute. This removes that filter, since it's now in core.

Why?

We don't need this if its in core.

How?

Just remove the code.

Testing Instructions

Check that you can still set Duotone filters in Gutenberg.

@github-actions
Copy link

Flaky tests detected in 7f66ecb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4566108354
📝 Reported issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant