Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "block-selectors" docs to TOC and manifest. #49471

Merged
merged 2 commits into from
Apr 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,12 @@
"markdown_source": "../docs/reference-guides/block-api/block-registration.md",
"parent": "block-api"
},
{
"title": "Selectors",
"slug": "block-selectors",
"markdown_source": "../docs/reference-guides/block-api/block-selectors.md",
"parent": "block-api"
},
{
"title": "Styles",
"slug": "block-styles",
Expand Down
7 changes: 7 additions & 0 deletions docs/reference-guides/block-api/block-selectors.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Selectors

<div class="callout callout-alert">
This API was stabilized in Gutenberg 15.5 and is planned for core release
in WordPress 6.3. To use this prior to WordPress 6.3, you will need to
install and activate Gutenberg >= 15.5.
</div>
<br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a line break added in other places, but we can verify once the handbook updates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the <br /> from the components package examples. IIRC, when testing it locally, without the line break the text moved up with no space between it and the callout. That could have been just previewing the markdown though 🤔


Block Selectors is the API that allows blocks to customize the CSS selector used
when their styles are generated.

Expand Down
3 changes: 3 additions & 0 deletions docs/toc.json
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,9 @@
{
"docs/reference-guides/block-api/block-registration.md": []
},
{
"docs/reference-guides/block-api/block-selectors.md": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it sorted by name?

},
{ "docs/reference-guides/block-api/block-styles.md": [] },
{ "docs/reference-guides/block-api/block-supports.md": [] },
{
Expand Down