Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable: Fix focusing the editable component #494

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

youknowriad
Copy link
Contributor

This fixed the regression introduced by #492 while we were not able to focus the Editable.
In the same time it ensures the block switcher is shown above the Editable component.

@youknowriad youknowriad added the Framework Issues related to broader framework topics, especially as it relates to javascript label Apr 24, 2017
@youknowriad youknowriad self-assigned this Apr 24, 2017
@ellatrix
Copy link
Member

LGTM :)

@youknowriad youknowriad merged commit 4cead66 into master Apr 24, 2017
@youknowriad youknowriad deleted the fix/focusing-editable branch April 24, 2017 13:48
@jasmussen
Copy link
Contributor

Weird, the z index in the switcher didn't work for me. But thank you to both of you for fixing my mess 💐

@youknowriad
Copy link
Contributor Author

@jasmussen yep it does not work on the switcher, I added a z-index to the parent div holding all the controls.

@youknowriad youknowriad mentioned this pull request Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants