-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duotone: Update to use selectors API #49325
Conversation
Size Change: +40 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The site editor breaks from
rather than a selector string, like |
Thanks for digging into the issue @jeryj 👍
I have a fix working locally for this. The issue though highlights that I need to update the |
Closing as these changes were absorbed into a single PR cleaning up the Selectors API (#49393). |
What?
Why?
How?
WP_Duotone_Gutenberg
to leverage the new global function for retrieving feature selectorsTesting Instructions
Note: The lack of the global duotone filter in the post editor is a known issue that is being worked on, see #49239.
Screenshots or screencast