Global Styles Sidebar: Re-add Colors: Heading to selected blocks #49131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +68 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 50e8e68. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5307939740
|
youknowriad
reviewed
Mar 20, 2023
|
FYI, in this PR #48893 where I'm refactoring the color components in both global styles and block inspector. I had to solve this issue as well within the refactoring. I mapped the behavior of the "button" colors. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks for working on this
The following blocks can contain headings:
I think we should enable all of this. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
carolinan
changed the title
carolinan
requested review from
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
aristath
reviewed
Apr 26, 2023
| @@ -35,7 +35,7 @@ export function useHasColorPanel( settings ) { | |||
| const hasBackgroundPanel = useHasBackgroundPanel( settings ); | |||
| const hasLinkPanel = useHasLinkPanel( settings ); | |||
| const hasHeadingPanel = useHasHeadingPanel( settings ); | |||
| const hasButtonPanel = useHasHeadingPanel( settings ); | |||
| const hasButtonPanel = useHasButtonPanel( settings ); | |||
There was a problem hiding this comment.
Good catch! This was a typo/remnant from the older implementation that was never changed 👍
aristath
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Great work @carolinan!
This is a simple change, the code looks good and works as expected.
LGTM 👍
There is a conflict that needs to be resolved, but other than that this looks good to merge 🎉
scruffian
approved these changes
Jun 30, 2023
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
WIP
Prior to #48893,
The panel at
Site Editor Styles > Blocks > Block name > Colorswould show a heading color option for all blocks that supported text color.This was incorrect, and solved in 48893.
This PR adds the Colors > Heading option back for selected blocks only, through opt-in in block.json.
Why?
These blocks has or can have headings inside them, and having this option in the Styles sidebar is a useful feature.
Testing Instructions
Screenshots or screencast
Before:
The Verse block has a heading color option in the Styles sidebar:
https://user-images.githubusercontent.com/7422055/225591043-2cd43ce7-aaf1-487f-9c3c-0d3f0f8f2413.mov
After:
The Verse block does not have a heading color option in the Styles sidebar:
https://user-images.githubusercontent.com/7422055/233548549-683c8dd2-62ee-4831-a169-7526aebaf05d.mp4