Navigation: Fix missing state for MenuControls #48921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The second path highlighted here will never be reached. Since the |
|
Size Change: -11 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
There has been some refactoring recently hence now some weird code. I think the second path should remain, so the messages are consistent. Plus we aim to remove the big rectangle in the canvas so adding the same message in the inspector helps on that path. |
draganescu
approved these changes
Mar 8, 2023
Sounds good. I will remove the first path and make messages consistent. |
|
Flaky tests detected in 79fc433. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4364681588
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes props passed to the missing navigation menu controls to avoid an infinite spinner in the sidebar.
How?
Add the missing
currentMenuIdto theMenuInspectorControls.Testing Instructions
ref-<!-- wp:navigation {"ref":9999} /-->.Screenshots or screencast
Before
After
