Site Editor: Improve the Navigation panel's menu query #48908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
Mamaduka
commented
Mar 8, 2023
Comment on lines
+29
to
+30
| order: 'desc', | ||
| orderby: 'date', |
There was a problem hiding this comment.
These two arguments aren't required since they are defaults, but I think it makes it easier to scan what query the component makes.
|
Size Change: +514 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 8, 2023
| @@ -66,17 +71,7 @@ export default function SidebarNavigationScreenNavigationMenus() { | |||
| }; | |||
| }, [] ); | |||
|
|
|||
| // Sort navigation menus by date. | |||
| const orderedNavigationMenus = useMemo( | |||
There was a problem hiding this comment.
Ì think we have similar code in the navigation menu block. Is it possible to replace that one too?
There was a problem hiding this comment.
Is it for the same post type? Because I couldn't find one where we order on the client-side.
There was a problem hiding this comment.
gutenberg/packages/block-library/src/navigation/edit/index.js
Lines 204 to 214 in 8a81086
There was a problem hiding this comment.
I think the request there includes "draft" menus but the ordering is probably something we can remove?
There was a problem hiding this comment.
Do you mind if I do that separately? Would be easier to revert if it affects anything in the Navigation block.
youknowriad
reviewed
Mar 8, 2023
packages/edit-site/src/components/sidebar-navigation-screen-main/index.js
Show resolved
Hide resolved
youknowriad
approved these changes
Mar 8, 2023
Mamaduka
added
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #48689.
PR improves REST API query for the Site Editor's navigation panel.
Why?
The component was fetching all published navigation menus and sorting them by date on the client side - this isn't necessary. The REST API can handle this directly.
How?
I've updated
NAVIGATION_MENUS_QUERYto fetch the last published navigation menu.Testing Instructions