Remove border from quick inserter child elements #48794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +331 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8d03edb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4345124003
|
jameskoster
added
the
Backport to WP 6.7 Beta/RC
Mamaduka
added
the
[Feature] Inserter
ntsekouras
pushed a commit
that referenced
this pull request
Mar 7, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 262cfdc |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
This was referenced Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the 'double-border' on quick inserter child elements.
Also fixes a small radius quirk.
Why?
Currently we're applying two borders, one via the
borderproperty, and one viabox-shadow. The result is a UI that feels inconsistent with the rest of the Editor.How?
Removes some CSS.
I removed the border instead of the shadow as that style was local to the quick inserter, while the shadow is applied to all popovers.I revised this to leave the border on the quick inserter children, and remove the one added by the shadow. The benefit to this approach is that the dark grey button at the bottom is not wrapped in an awkward light grey border.Testing Instructions
Screenshots or screencast