Rich text: only consider a format active if active at every selected index #48789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
|
Size Change: +267 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 42c8102. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4346189616
|
getdave
reviewed
Mar 6, 2023
|
I will have to review |
|
I tested this change in the native version and works as expected. However, I'm not sure if I'm covering all the functionality. @ellatrix I'm wondering if we could add instructions to the Testing Instructions section , WDYT? Sharing a video capture of the test I did on an iOS simulator. Observe the format active in the toolbar at the bottom when selecting text.
|
|
@fluiddot Added instructions. Idk, it's good to play around with formatting and check if everything works as expected. Recordings are looking great. |
getdave
approved these changes
Mar 8, 2023
|
@ellatrix This looks good to go no? |
|
Yes, sorry, was AFK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently we consider all formats at the start index as active formats. It seems to make more sense to check if it's active at every selected index, which is why an exception was made for link. This PR changes it for all other formats.
The current behaviour we have was taken directly from TinyMCE and CKEditor, while this new behaviour is what Google Docs does.
Why?
To remove inconsistencies and exceptions for the link format.
How?
Testing Instructions
Generally make sure formatting works as expected.
Testing Instructions for Keyboard
Screenshots or screencast