Fix flaky block hierarchy navigation test by better inserter selection #48780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Thank you for starting this! I noticed that now the test failed though. I think it is related? |
|
Yes, it is related. I changed two tests. One, "should navigate block hierarchy using only the keyboard", passed, the other, "should navigate using the list view sidebar", is now failing even more 🙂 I'll need to continue working on this. |
|
If it's too much trouble fixing the existing tests, maybe refactoring them to Playwright would help? We can get rid of all the |
jsnajdr
force-pushed
the
fix/flaky-e2e-hierarchy-navigation
branch
from
f3783e7 to
d51885e
Compare
Turns out this assumption is completely wrong. In the inserter the blocks are ordered by "frecency", so as soon as the test inserts a "Columns" block, it becomes the first block in the inserter list. I had to update the fix by directly waiting for a CSS selector (the paragraph list item) and then clicking on it.
If the second attempt at a fix will also fail, I'll give up and consider the Playwright migration 🙂 |
|
After the latest fixes the e2e tests are green, so I think the PR is ready for review and merging. |
alexstine
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
This is probably an okay solution until this gets migrated to playwright. Generally, I think the goal is to try to avoid hardcoding classes. @kevin940726 should probably be the deciding voice on this.
kevin940726
approved these changes
Mar 8, 2023
We could also find the Paragraph block inserter item by looking for a11y properties: role "option" and label "Paragraph". Is that possible and convenient to do in Puppeteer? Or do we need to migrate to Playwright first and only then use their |
|
@jsnajdr Playwright makes all of this easier. Should be fine waiting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix a flaky e2e test tracked in #47001, where @kevin940726 reports:
Apparently there are issues with inserting a Paragraph block into a Column, because the failed snapshots show that a Heading was inserted instead.
I'm trying to fix this by improving the code that opens the block inserter and selects the Paragraph block from there. The old code types "paragraph" into the search box and then presses Tab twice, once to tab to the "Reset search" button, and second time to the search results. I think the test did that tabbing before the search results appeared.
The new code relies on the fact that the Paragraph block is always the first in the list, so we don't search: we just Tab to the first result.
We already did similar fixes in #47173, during the concurrent mode migration.