Columns Block: Don't show the column count change UI when templateLock is all
#48691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Feature] Inserter
|
Size Change: +31 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Thanks for the ping @t-hamano, this PR's testing nicely for me for the templateLock all case, while not causing any unrelated issues for the Column(s) blocks 👍
One thing I noticed in testing is that there's another case that might be good to try to handle, which is when blocks are locked via the lock attribute or via the UI for locking. For example, if I go to lock individual column blocks against removal, but then move up to the parent Columns block, then I can still adjust the slider to remove the column blocks:
columns-lock.mp4
This isn't strictly speaking related to templateLock, though, and the fix in this PR still looks like a good approach to me, so I don't think this is a blocker.
This LGTM! ✨
|
Thank you for the review, @andrewserong!
This is a bit of a complicated issue. Because we also need to consider the case where only some columns are locked. For example, only one of the four columns is locked, as shown below:
If the number of columns is reduced, the columns are removed from the back of the list. If I change the number of columns from 4 to 2 in the text control, I would expect the following layout:
In other words, the logic is to delete columns in order from the back, and if a locked column is hit, no more columns are deleted. I will try to resolve this issue in another PR 👍 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #48620 (comment)
What?
This PR hides the column change UI in the sidebar if the
core/columnsblock hastemplateLock=all, i.e., thecore/columnblock is not allowed to be inserted.Why?
If
templateLockisall, no inner blocks are allowed to be inserted. However, by using the slider to change the number of columns, it is possible to insert columns that are in fact inner blocks. Given the role of templateLock, I think it should not be the intent that the UI can be manipulated.How?
I used
canInsertBlockType()to not show the column change UI if thecore/columnsblock is in a context where it cannot be inserted.Testing Instructions
Use the following HTML to insert a group block with
templateLock=allset.Confirm that the column count change UI is not displayed when selecting a
core/columnsblock in a group block.Screenshots or screencast
Before
After