List Item: Avoid an error when the 'onReplace' prop is undefined #48639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
mcsf and
ellatrix
and removed request for
ajitbohra
|
Size Change: +2 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
This looks good, thanks!
Separately from the fix, I'm wondering though if we should consider list-item as content here.. 🤔 --cc @jorgefilipecosta
We should not consider list-item as content. We should consider the list as content. Otherwise, the content sidebar becomes polluted with every list item as an item and things become less intuitive for the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #48324.
PR adds a check to avoid an error when the
onReplaceprop isundefined. Updated behavior matches the Paragraph block - where pressing enter doesn't create a new block.Why?
The
onReplacemethod can be undefined based on the block's or its parent's lock state.Testing Instructions
Example markup
Screenshots or screencast
CleanShot.2023-03-01.at.18.06.56.mp4