[WP6.2] Revert dynamic block anchor support #48592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
requested review from
michalczaplinski,
tellthemachines,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
t-hamano
removed request for
juanmaguitar,
ajitbohra,
ryanwelcher,
michalczaplinski,
tellthemachines and
fabiankaegy
|
I think there's no need to keep PHP changes in the |
Makes sense, reverted. |
|
Flaky tests detected in 235f68e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4300157637
|
This was referenced Mar 1, 2023
|
The E2E test is failing but does not appear to be related to this PR. |
Mamaduka
force-pushed
the
revert/dynamic-block-anchor-support
branch
from
6d71513 to
235f68e
Compare
|
Rebased the branch. The issue should be fixed after this backport #48206 (comment). |
Mamaduka
added
[Type] Bug
Mamaduka
approved these changes
Mar 1, 2023
|
Thanks for the response, @Mamaduka! I would like to start with the following next steps.
|
|
@t-hamano, I already handled that this morning - https://core.trac.wordpress.org/ticket/57830#ticket. |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 1, 2023
[55230] introduced a regression to the content markup. This changeset is a partial revert to remove the added `wp-includes/block-supports/anchor.php` file. The change of adding `'id'` to `$attributes_to_merge` in `get_block_wrapper_attributes()` is not reverted as this change did not impact the regression and helps to support continue development in Gutenberg for the anchor support in dynamic blocks feature. Reference: * [WordPress/gutenberg#48592 Gutenberg PR 48592]. Follow-up [55230]. Props wildworks, mamaduka, hellofromTonya. Fixes #57830. See #56852. git-svn-id: https://develop.svn.wordpress.org/trunk@55443 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 1, 2023
[55230] introduced a regression to the content markup. This changeset is a partial revert to remove the added `wp-includes/block-supports/anchor.php` file. The change of adding `'id'` to `$attributes_to_merge` in `get_block_wrapper_attributes()` is not reverted as this change did not impact the regression and helps to support continue development in Gutenberg for the anchor support in dynamic blocks feature. Reference: * [WordPress/gutenberg#48592 Gutenberg PR 48592]. Follow-up [55230]. Props wildworks, mamaduka, hellofromTonya. Fixes #57830. See #56852. Built from https://develop.svn.wordpress.org/trunk@55443 git-svn-id: http://core.svn.wordpress.org/trunk@54976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Mar 1, 2023
[55230] introduced a regression to the content markup. This changeset is a partial revert to remove the added `wp-includes/block-supports/anchor.php` file. The change of adding `'id'` to `$attributes_to_merge` in `get_block_wrapper_attributes()` is not reverted as this change did not impact the regression and helps to support continue development in Gutenberg for the anchor support in dynamic blocks feature. Reference: * [WordPress/gutenberg#48592 Gutenberg PR 48592]. Follow-up [55230]. Props wildworks, mamaduka, hellofromTonya. Fixes #57830. See #56852. Built from https://develop.svn.wordpress.org/trunk@55443 git-svn-id: https://core.svn.wordpress.org/trunk@54976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
[55230] introduced a regression to the content markup. This changeset is a partial revert to remove the added `wp-includes/block-supports/anchor.php` file. The change of adding `'id'` to `$attributes_to_merge` in `get_block_wrapper_attributes()` is not reverted as this change did not impact the regression and helps to support continue development in Gutenberg for the anchor support in dynamic blocks feature. Reference: * [WordPress/gutenberg#48592 Gutenberg PR 48592]. Follow-up [55230]. Props wildworks, mamaduka, hellofromTonya. Fixes #57830. See #56852. Built from https://develop.svn.wordpress.org/trunk@55443 git-svn-id: http://core.svn.wordpress.org/trunk@54976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes
anchorsupport fromblock.jsonin dynamic blocks, among changes made in #44771.Why?
As reported by #48232, a problem was found in backward compatibility. A resolution was attempted in #48438, but more discussion and exploration are needed, so we have decided to revert this feature in the WordPress 6.2 release.
How?
As noted in this comment, we will follow these steps:
block.jsonanchor support from Add anchor support for dynamic blocks #44771.block-supports/anchor.phpfrom the core.$attributes_to_mergechange in the core so that the feature can be implemented from the plugin.This PR falls under the first step of the above.
First of all, I reverted the commit made in #44771. Then I re-added the PHP and documentation changes that did not need to be changed in this step.