Navigation: Don't create duplicate wp_navigation CPTs when updating inner blocks #48587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +26 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
This is very similar to the original fix I proposed in #47884. |
@scruffian Please could you add a little more detail around this? All your changes are to the Navigation block itself yet here you refer to the Navigation Link block. |
|
I we go with this then we won't need this PR |
scruffian
added
the
[Status] Blocked
|
This was made obsolete by the new fallbacks endpoint. Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When creating a navigation menu from the state of navigation when it has uncontrolled inner blocks, we are currently creating two wp_navigation CPTs. This is because
blocksgets modified by the Navigation Link block edit component, triggering theuseEffecttwice.To avoid this I tried using the status of the
useCreateNavigationMenuhook, but the problem with this approach is that state is set asynchronously, whereas the changes toblockshappens immediately, so the useEffect is still called twice.To get around this I have tried using a ref which stores the state of the useEffect allowing us to ensure that it is only called once. This feels like a bit of a work around, but I couldn't think of a better option, except removing
blocksfrom the dependencies (#48220).Testing Instructions