Sort templates and template parts by slug #48473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Should we push custom ones to the bottom here too? |
I'm not certain, I feel for instance that ideal "Page" and "Custom Page" should be close to each other but that's hard to know using a sort algorithm. If we do push custom ones to the bottom, maybe we should separate them somehow in the UI? |
|
Size Change: +69 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Probably, yes. We'd want to introduce some visual separators in that case. Seems fine to start at least with this and refine. |
mtias
approved these changes
Feb 27, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 19af130 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
|
Should we follow up to push 404 to the bottom of the list? There's something a little awkward about seeing it at the top 🤔 |
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #38378
What?
The list of templates and template parts in the site editor is sorted randomly using the "last save date". This PR applies a more consistent sorting algorithm (sort by slug/name).
How
The REST API for templates/template parts don't support sorting yet, I decided to not implement it there, that late in 6.2 cycle and just went with a JS sort since we already have all the templates locally.
Testing Instructions
1- Open the site editor
2- Make edits to templates or template parts
3- The order in the sidebar should remain stable.