Prevent distracting focused back button on site editor load #48472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
commented
Feb 27, 2023
| box-shadow: none; | ||
| outline: none; | ||
| } | ||
| &:focus-visible:not(:disabled) { |
There was a problem hiding this comment.
I wonder at what point we could consider this globally for all buttons and not just this override. cc @ciampo
There was a problem hiding this comment.
That would be a nice improvement, and in general I'd be up for bringing it to the source component.
The only challenge would be to make sure that there are no regressions when introducing the change. Button is a very complex component and it's not easy to grasp the extend of the consequences when making a change.
Would you be able to open a separate issue about this?
|
Size Change: +103 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0c107ac. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4280537036
|
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 82549ea |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading the site editor in trunk, the "back button" is focused initially because the "initial path" of the sidebar is incorrect causing the "Navigator" component to "focus" the screen.
Also, when navigating between screens, the focus style is a bit distracting.
This PR fixes both of these issues by computing the right initial path and by using focus-visible instead of focus.