-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - E2E tests - Add new helpers #48358
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a619c2c
Mobile - Editor Page - Add getButtonBlockTextInputAtPosition
98339d3
Mobile - Buttons block - Fix issue when creating a new button using t…
85d556e
Mobile - E2E Tests - Adds selectTextFromTextInput util, toggleFormatt…
4b5f2e2
Mobile - E2E Editor Page - Update dismissKeyboard to support landscap…
a211d3f
Mobile - E2E Utils - Wait for selection toolbar to show up
fd8255d
Mobile - E2E helpers - Add getToobal helper
c6cb481
Mobile - E2E utils - Rename selectTextFromTextInput to selectTextFrom…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike the web, this element does not appear accessible to screen readers, i.e.
accessible
is not enabled. Was the intent to make this selectable or should we removeaccessibilityLabel
?Enabling
accessible
would change the interaction with the child elements, e.g. insert block button, undo button. The web has keyboard commands to "step into" an element to select a child. I do not believe mobile devices have a similar mechanism, we would likely have to recreate an experience similar to how selecting a block disablesaccessible
on the ancestor so that descendent UI is selectable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added these to be able to find them for E2E tests, since
testID
is not supported on Android we also have to addaccessibilityLabel
so it'd be for internal usage only.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha. That is very helpful context. Thank you for explaining that. That is unfortunate. 😞 Is it worth leaving an inline comment stating it is currently only used for testing purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we have other cases like these around the codebase, so I'm not sure if having several comments explaining why would be the best approach. I feel like if it's next to a
testID
it could be self-explanatory once you know it is needed for E2E tests.