[Block Library - Post Terms]: Add transforms for variations #48328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 8a15936. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4244861552
|
andrewserong
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Great idea, and very cool that it only involved changing a couple of lines of code 👍
This is testing well — with no plugins other than Gutenberg installed, the icons approach is used as the Tags and Categories have unique icons. With a plugin like WooCommerce installed, that doesn't have unique icons for each of the variations / taxonomies, the dropdown list is used:
| Only GB installed | WooCommerce installed |
|---|---|
 |
 |
Switching between the variations is working nicely, too. LGTM! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Post Terms variations are created dynamically based on the registered public(and with REST support) taxonomies. This PR enables these variations to be easily switched through the transform variations UI in block inspector controls.
Testing Instructions
post termsblock variation - a basic example would be to insertCategoriesvariation through the inserter.Notes
The transform variation UI shows icons if all variation have an icon and all icons are unique. If this is not true, it renders a dropdown list.
Unique icons
Screen.Recording.2023-02-22.at.6.22.12.PM.mov
Dropdown
Screen.Recording.2023-02-22.at.6.18.08.PM.mov