Remove broken site editor redirect #48283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
jameskoster,
jorgefilipecosta and
jasmussen
|
Size Change: -21 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
What's the impact on older versions? We have to support WP 6.1 in the Gutenberg plugin until 6.3 is released. |
|
The impact is mentioned in the description:
It's the sidebar state that will be different, it's like you'll be in a child screen of navigation and not the root level of the site editor. |
|
Sorry, not sure how I missed that 🤦♂️ Catching up with a lot of things today 😅 The code looks good to me, but I will test with different versions of WP and leave a final review shortly 👍 |
|
@youknowriad can you rebase the PR? Thanks! |
youknowriad
force-pushed
the
fix/remove-site-editor-redirect
branch
from
e3aa6a9 to
29b1bbd
Compare
Mamaduka
approved these changes
Feb 28, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: d09d368 |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 28, 2023
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
This was referenced Mar 16, 2023
IanRamosC
pushed a commit
to Automattic/jetpack
that referenced
this pull request
Jun 12, 2024
Gutenberg 15.2 introduced a core compat redirect for the Site Editor that the WoA site in question from being logged-in. It was already removed: WordPress/gutenberg#48283 Fixes Automattic/wp-calypso#74072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In previous WP versions, when you load the site editor, we used to fetch the home page and redirect to it (adding some params to the url), we don't rely on this behavior anymore and in order to "cancel" the redirect in Gutenberg we had a filter that was supposed to do that. The problem is that that filter doesn't work properly:
I'm removing that redirect in this filter. The impact of this change is that in previous WP versions when you load the site editor, it won't load the site editor sidebar in the "root" screen, instead it will load the "home page" that is set as static and opens it in the site editor. I think this is not perfect but it's fine.
Testing
There shouldn't be any impact here unless you explicitly load an old WP version (6.1) in addition to the Gutenberg plugin.