Fix the Publish region position and focus style. #48102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +269 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dbc55f4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4185680376
|
|
Thanks for opening the PR @afercia For the part about the sidebar panel position (the top: auto), I was actually aware of it, but my thinking was that it's the same region, same sidebar, it doesn't matter whether the sidebar is "full" or not, we can always show it in the same way (a sidebar from top to bottom) which would prevent us from adding this logic (extra classes...) to adapt the design. So personally, I don't feel strongly that the buttons should necessarily be at the bottom right but I don't mind it either. |
youknowriad
approved these changes
Feb 16, 2023
|
That's an interesting idea @youknowriad. Showing the sidebar always full height could be a better option also for accessibility, as it would be more visible and intuitive. However, for consistency, we should change it in both the post editor and site editor, also for the 'settings' sidebar. I will create a new issue for consideration. The current situation on trunk is a bit inconsistent:
|
afercia
deleted the
fix/publish-navigate-region-position-and-focus-style
branch
ntsekouras
pushed a commit
that referenced
this pull request
Feb 20, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: d926743 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48031
What?
This PR seeks to fix regressions after #47734. (and maybe also #47142) where the position of the Publish/Save panel is off when navigating through the editor regions.
#47734 fixed the position of the multi-entity save panel but broke the position of the Publish/Save panel when navigating through the editor regions.
It would be great to include this fix in the WP beta, as it fixes a regression. Cc @youknowriad
Why?
Layout and focus style are off, see screenshots on #48031
How?
topposition toauto.topposition to0only when the multi-entity save panel is rendered.Testing Instructions
Post editor:
Site editor:
Testing Instructions for Keyboard
See above.
Screenshots or screencast