Site Editor: tidy up the generation of the site editor page title #48053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Feature] Site Editor
glendaviesnz
commented
Feb 13, 2023
| ); | ||
| const isReady = editedPostType !== undefined && editedPostId !== undefined; | ||
|
|
There was a problem hiding this comment.
This didn't seem to add anything over and above isLoaded from useEditedEntityRecord. In my testing editedPostType and editedPostId where always defined when isLoaded === true , but I may have missed an edge case where this isn't the case.
|
Size Change: -83 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fd52e8a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4168550632
|
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
|
Thanks for the follow-up. This looks great. |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 14, 2023
…8053) * Tidy up the generation of the edit site page title * Remove isReady as doesn't seem to add anything above the isLoaded from useEditedEntityRecord
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
sprintfinstead of concatination for the generation of page title breadcrumbuseEditedEntityRecordto get current edited post details instead of getting the post info via the useSelectWhy?
Changes were suggested in post merge follow up.
How?
As noted under
What?aboveTesting Instructions
Screenshots or screencast
page-title-after.mp4