Apply keyboard shortcut conversions between paragraphs and headings to all editor instances #47972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Feb 10, 2023
Comment on lines
-184
to
+187
| name: `core/block-editor/transform-heading-to-paragraph`, | ||
| name: `core/edit-post/transform-heading-to-paragraph`, |
There was a problem hiding this comment.
I think the namespace should be unified.
|
Size Change: +1.01 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
t-hamano
commented
Feb 10, 2023
Comment on lines
+74
to
+84
| const textAlign = | ||
| blockName === 'core/paragraph' ? 'align' : 'textAlign'; | ||
| const destinationTextAlign = | ||
| destinationBlockName === 'core/paragraph' ? 'align' : 'textAlign'; | ||
|
|
||
| replaceBlocks( | ||
| currentClientId, | ||
| createBlock( destinationBlockName, { | ||
| level, | ||
| content: currentContent, | ||
| align: currentAlign, | ||
| content: attributes.content, | ||
| ...{ [ destinationTextAlign ]: attributes[ textAlign ] }, |
There was a problem hiding this comment.
Heading block and paragraph block have different property name for text alignment:
- Heading Block:
textAlign - Paragraph Block:
align
Therefore, property name and value must be properly mapped.
t-hamano
added
[Type] Enhancement
|
Flaky tests detected in f7e0a41. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4229265049
|
…o all editor instances
t-hamano
force-pushed
the
enhancement/paragraph-top-heading-shortcut
branch
from
33cfa17
to
54dff7d
Compare
t-hamano
commented
Feb 11, 2023
t-hamano
requested review from
kevin940726,
noisysocks,
tellthemachines and
adamziel
as code owners
kevin940726
force-pushed
the
enhancement/paragraph-top-heading-shortcut
branch
3 times, most recently
from
af6efee
to
2c8ea0b
Compare
kevin940726
approved these changes
Feb 16, 2023
draganescu
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on: #44681
What?
This PR adds conversion keyboard shortcuts between paragraphs and headings to all editors, in addition to the post editor.
How?
In addition to adding shortcuts, the following actions have been taken:
Testing Instructions
In the post/edit-site/edit-widgets/customize-widgets, check the following: